-
-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(experience): cache user input identifier for a better sign-in experience #6164
Open
xiaoyijun
wants to merge
3
commits into
master
Choose a base branch
from
xiaoyijun-log-4958-cache-input-value-so-it-can-be-retrieved-when-click-on-back
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
refactor(experience): cache user input identifier for a better sign-in experience #6164
xiaoyijun
wants to merge
3
commits into
master
from
xiaoyijun-log-4958-cache-input-value-so-it-can-be-retrieved-when-click-on-back
+381
−216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
COMPARE TO
|
Name | Diff |
---|---|
packages/experience/src/Providers/UserInteractionContextProvider/UserInteractionContext.tsx | 📈 +1.61 KB |
packages/experience/src/Providers/UserInteractionContextProvider/index.tsx | 📈 +1.46 KB |
packages/experience/src/components/InputFields/SmartInputField/use-smart-input-field.ts | 📈 +233 Bytes |
packages/experience/src/containers/ForgotPasswordLink/index.tsx | 📈 +474 Bytes |
packages/experience/src/containers/VerificationCode/PasswordSignInLink.tsx | 📈 +220 Bytes |
packages/experience/src/containers/VerificationCode/index.tsx | 📈 +36 Bytes |
packages/experience/src/hooks/use-check-single-sign-on.ts | 0 Bytes |
packages/experience/src/hooks/use-global-redirect-to.ts | 📈 +510 Bytes |
packages/experience/src/hooks/use-send-verification-code.ts | 📈 +37 Bytes |
packages/experience/src/hooks/use-session-storages.ts | 📈 +303 Bytes |
packages/experience/src/pages/Continue/SetEmailOrPhone/index.tsx | 📈 +273 Bytes |
packages/experience/src/pages/Continue/SetUsername/index.tsx | 📈 +274 Bytes |
packages/experience/src/pages/ForgotPassword/ForgotPasswordForm/index.test.tsx | 📈 +148 Bytes |
packages/experience/src/pages/ForgotPassword/ForgotPasswordForm/index.tsx | 📈 +379 Bytes |
packages/experience/src/pages/ForgotPassword/index.test.tsx | 📈 +541 Bytes |
packages/experience/src/pages/ForgotPassword/index.tsx | 📈 +4 Bytes |
packages/experience/src/pages/Register/IdentifierRegisterForm/index.test.tsx | 📈 +580 Bytes |
packages/experience/src/pages/Register/IdentifierRegisterForm/index.tsx | 📈 +403 Bytes |
packages/experience/src/pages/ResetPassword/index.tsx | 📈 +363 Bytes |
packages/experience/src/pages/SignIn/IdentifierSignInForm/index.test.tsx | 📈 +722 Bytes |
packages/experience/src/pages/SignIn/IdentifierSignInForm/index.tsx | 📈 +402 Bytes |
packages/experience/src/pages/SignIn/IdentifierSignInForm/use-on-submit.ts | 📈 +139 Bytes |
packages/experience/src/pages/SignIn/PasswordSignInForm/index.tsx | 📈 +272 Bytes |
packages/experience/src/pages/SignInPassword/PasswordForm/index.test.tsx | 📈 +42 Bytes |
packages/experience/src/pages/SignInPassword/PasswordForm/index.tsx | 📈 +266 Bytes |
packages/experience/src/pages/SignInPassword/index.test.tsx | 📈 +320 Bytes |
packages/experience/src/pages/SignInPassword/index.tsx | 📈 +26 Bytes |
packages/experience/src/pages/VerificationCode/index.test.tsx | 📈 +516 Bytes |
packages/experience/src/pages/VerificationCode/index.tsx | 📈 +29 Bytes |
packages/experience/src/types/guard.ts | 📈 +69 Bytes |
CI failed |
74da055
to
5dc2e45
Compare
184e22c
to
2e56683
Compare
cb63d08
to
bdaea40
Compare
simeng-li
reviewed
Jul 4, 2024
packages/experience/src/pages/SignIn/IdentifierSignInForm/index.tsx
Outdated
Show resolved
Hide resolved
packages/experience/src/pages/ForgotPassword/ForgotPasswordForm/index.tsx
Outdated
Show resolved
Hide resolved
Base automatically changed from
xiaoyijun-log-9515-refactor-ssocontextprovider
to
master
July 4, 2024 02:52
bdaea40
to
405183f
Compare
405183f
to
a4de3a2
Compare
0bb2f11
to
6f7f4e2
Compare
simeng-li
reviewed
Jul 4, 2024
packages/experience/src/Providers/UserInteractionContextProvider/UserInteractionContext.tsx
Outdated
Show resolved
Hide resolved
6f7f4e2
to
9dece09
Compare
9dece09
to
b97b3be
Compare
simeng-li
approved these changes
Jul 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall LGTM
packages/experience/src/Providers/UserInteractionContextProvider/UserInteractionContext.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a significant refactoring of the user input identifier caching mechanism to enhance the sign-in experience. The main changes include:
These changes aim to provide a more seamless and consistent experience for users across different authentication flows, reducing the need for re-entering information and improving overall usability.
The refactoring touches multiple files across the experience package, primarily focusing on state management and data persistence between different steps of the authentication process.
Testing
Test locally and all IT passed.
Checklist
.changeset