Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node 16 requirement #1

Open
Dutch77 opened this issue Apr 4, 2022 · 5 comments
Open

Node 16 requirement #1

Dutch77 opened this issue Apr 4, 2022 · 5 comments
Labels
question Further information is requested

Comments

@Dutch77
Copy link

Dutch77 commented Apr 4, 2022

Is node 16 really neccessary?

@logue
Copy link
Owner

logue commented Apr 5, 2022

I set it to 16 simply because it's a long-term stable (LTS).

@ricardo17coelho
Copy link

and node 18.15 is also necessary for LTS ?
I add this project and dependency and start work with it 2-3 weeks ago... i need to update my node env to v. 18.14.. (was already a challenge) and now the project was updated again to v. 18.15 😔

@Dutch77
Copy link
Author

Dutch77 commented Mar 20, 2023

@logue

  "peerDependencies": {
    "vue": "^2.7.14 || ^3.2.47"
  },

also this forces user update vue to up to this version. Minor/feature lock is understandable, but you do not want force patch version. Just lock it at version that your project need for running please.

Sometimes it can be really diffucult to meet requirements because of this.

Same thing applies to locked version of node 18. At the time I was writing this issue, your package run perfectly fine with node 14. No every project can be upgraded to such version. Just lock it on minimal version possible please.

@logue
Copy link
Owner

logue commented Mar 23, 2023

I understand about the version of node.
From now on, I will put the version defined in Vue used for development. (Currently >=16.11.0)
https://github.com/vuejs/core/blob/main/package.json

Regarding peerDependencies, vue2.6.x was the minimum version, but expose was not implemented, and there was a problem that it did not work, so we could not carelessly lower the minimum version.

However, since I think that it will work with Vue 3.2 or later, a minor version may not be necessary there.

@logue
Copy link
Owner

logue commented Mar 23, 2023

After much thought, I came to the conclusion that the dependency version should be determined in the base Vue and not defined in the component.

logue added a commit that referenced this issue Mar 23, 2023
The underlying Vue should be determined by the dependency version and not defined in the component.
@logue logue added the question Further information is requested label Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants