Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove sending extension logs #25

Merged
merged 4 commits into from
Jul 11, 2022
Merged

remove sending extension logs #25

merged 4 commits into from
Jul 11, 2022

Conversation

mirii1994
Copy link
Contributor

This PR remove the ability to register the extension to receive extension logs.
When this feature is enabled, the logs arrive with many escape characters.
Removing this feature will not prevent from extension logs to appear in cloudwatch, it will only mean that we will not be sending them to Logz.io.
Closes #18 .

Copy link

@Doron-Bargo Doron-Bargo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mirii1994 mirii1994 merged commit e33f3fc into main Jul 11, 2022
@mirii1994 mirii1994 deleted the 0.3.1 branch July 11, 2022 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log-Escape-Ception if ENABLE_EXTENSION_LOGS=true
2 participants