Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV-31192: Fixed injection abilities #299

Merged
merged 1 commit into from
Mar 31, 2022
Merged

DEV-31192: Fixed injection abilities #299

merged 1 commit into from
Mar 31, 2022

Conversation

alexpalchuk
Copy link
Collaborator

According to best practices for xml parsing added disabling injections

Copy link
Collaborator

@DanMelman DanMelman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alexpalchuk alexpalchuk merged commit 0d59269 into master Mar 31, 2022
@alexpalchuk alexpalchuk deleted the DEV-31192-fix branch March 31, 2022 06:56
@barakm
Copy link
Contributor

barakm commented Mar 31, 2022

@alexpalchuk I think we need another test that validated remote resource loading (over HTTP) along with the file system based one.

@alexpalchuk
Copy link
Collaborator Author

@alexpalchuk I think we need another test that validated remote resource loading (over HTTP) along with the file system based one.

ok, will add it

@alexpalchuk
Copy link
Collaborator Author

@alexpalchuk I think we need another test that validated remote resource loading (over HTTP) along with the file system based one.

added in #300

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants