disallow using Mustache Partials #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* adding SafeMustacheCustomVisitorFactory * update others to use it also
DanMelman
reviewed
May 17, 2022
...-core/src/main/java/io/logz/sawmill/mustache/factories/SafeMustacheCustomVisitorFactory.java
Outdated
Show resolved
Hide resolved
...-core/src/main/java/io/logz/sawmill/mustache/factories/SafeMustacheCustomVisitorFactory.java
Show resolved
Hide resolved
DanMelman
approved these changes
May 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of this PR, we upgraded also the mustache version to 0.9.10.
We could have different approach and even not upgrade the mustache version and do it a bit differently (by using
FileSystemResolverand customize that theworking_directory), but decided to be more aligned with our current approach and also to disallow any file reference in this case even if it's located inside ourworking_directory.