Skip to content
This repository has been archived by the owner on Jan 5, 2023. It is now read-only.

fixes #96 #100 #102

Merged
merged 1 commit into from
May 4, 2022
Merged

fixes #96 #100 #102

merged 1 commit into from
May 4, 2022

Conversation

ncdm-stldr
Copy link

@ncdm-stldr ncdm-stldr commented Feb 9, 2022

There are reports of a crash happening with newer versions of flutter (issues #96 and #100).
This pull request aims to solve the crash.

Explanation of the changes:

  • The renderer.close() in getPage sometimes creates an exception. It is because the close is already preformed by the try-catch clause itself. The code renderer.close() can therefore be safely removed.
  • A else block has been added because it was missing (e.g. result should not been used twice).

@ncdm-stldr ncdm-stldr mentioned this pull request Feb 9, 2022
@bruce-brookshire
Copy link

@lohanidamodar Can we get this merged soon? Great fix, needs to go in to unblock our development. Thanks

@husainazkas
Copy link

Ping @lohanidamodar

@joymyr
Copy link

joymyr commented Feb 16, 2022

@bruce-brookshire You can reference this branch in pubspec.yaml as a temporary workaround like this:
advance_pdf_viewer: git: https://github.com/ncdm-stldr/pdf_viewer.git

@tsvillain
Copy link

@lohanidamodar Please Merge this and create a new release on pub.dev

@abhikhedekar4241
Copy link

@lohanidamodar Great fix, needs to unblock our development. Please get it merged soon.

@ncdm-stldr
Copy link
Author

There is also this package which doesn't have the issue: https://pub.dev/packages/advance_pdf_viewer_fork

@ManuelRosa
Copy link

@lohanidamodar would it be possible to get this merged and released to pub.dev? The code is simple and seems sound

@lohanidamodar lohanidamodar merged commit d5c395a into lohanidamodar:develop May 4, 2022
@igoswamirohit
Copy link

igoswamirohit commented Jun 1, 2022

@lohanidamodar Can you please merge the Changes into your Master branch and Publish it on pub.dev ?

@rivella50
Copy link

rivella50 commented Jun 2, 2022

@bruce-brookshire You can reference this branch in pubspec.yaml as a temporary workaround like this: advance_pdf_viewer: git: https://github.com/ncdm-stldr/pdf_viewer.git

It works fine with that version but as soon as i publish my app in release mode it crashes when trying to access cloud_firestore.
Seems to me that this package uses too old versions of certain dependencies.

@UBONGFX
Copy link

UBONGFX commented Jun 20, 2022

Hello @lohanidamodar,
we all would be very grateful if you would merge the
changes into the master branch and publish it on pub.dev.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet