Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/Controllers-Project #189

Merged
merged 4 commits into from Feb 10, 2019
Merged

Feature/Controllers-Project #189

merged 4 commits into from Feb 10, 2019

Conversation

nimrodolev
Copy link
Contributor

Changes

  • Created the BaGet.Controllers project
  • Moved all controllers + HttpRequestExtensions, IRouteBuilderExtensions and UrlExtensions to new project
  • Small DI change to fix issues with the tests (as suggested by @WernerMairl)

Addresses #180

@nimrodolev
Added BaGet.Controllers.csproj to the solution
2105b3a
@nimrodolev
Moved controllers and associated code to the BaGet.Controllers project
9e16fcf
@nimrodolev
Fixed tests after extraction of controllers into dedicated project
715193d 
By adding a call to `AddApplicationPart` to the service registration in the ServiceCollectionExtensions.ConfigureHttpServices method, registering the new assembly that contains the controllers.
@nimrodolev
Merge branch 'master' of github.com:loic-sharma/BaGet
ac8d746 
Merged changes from loic-sharma/BaGet that have been done while working on this PR
@nimrodolev nimrodolev mentioned this pull request Jan 7, 2019
Open
@loic-sharma loic-sharma changed the base branch from master to api February 10, 2019 23:24
@loic-sharma loic-sharma merged commit 62d6fe9 into loic-sharma:api Feb 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nimrodolev @loic-sharma