Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unclosed XML tag in PackageReference syntax #737

Merged
merged 1 commit into from
Jun 30, 2022
Merged

Fix unclosed XML tag in PackageReference syntax #737

merged 1 commit into from
Jun 30, 2022

Conversation

nloum
Copy link
Contributor

@nloum nloum commented Jun 29, 2022

When you want to add a dependency from a BaGet server, you have the option to copy the <PackageReference> element that would go in the .csproj file. However the element you copy is malformed: it is unclosed. E.g., here's what you copy:

<PackageReference Include="Mypackage" Version="1.2.3">

What you should copy is this:

<PackageReference Include="Mypackage" Version="1.2.3"/>

Notice the /> at the end. The backslash was missing. This PR fixes that.

@loic-sharma loic-sharma merged commit 4a7086e into loic-sharma:main Jun 30, 2022
@loic-sharma
Copy link
Owner

Thanks for the contribution!

zimbres added a commit to zimbres/BaGet that referenced this pull request Oct 6, 2022
Fix unclosed XML tag in PackageReference syntax (loic-sharma#737)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants