Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telephone Links #8

Closed
midzer opened this issue Sep 20, 2020 · 8 comments
Closed

Telephone Links #8

midzer opened this issue Sep 20, 2020 · 8 comments
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest

Comments

@midzer
Copy link
Member

midzer commented Sep 20, 2020

Link telephone number in info block like <a href="tel:+01-562-867-5309">1-562-867-5309</a>

and style it

a[href^="tel:"]:before {
  content: "\260e";
  margin-right: 0.5em;
}

Don't forget to add the extra hypens in the link.

Reference: https://css-tricks.com/the-current-state-of-telephone-links/

@midzer midzer added enhancement New feature or request good first issue Good for newcomers labels Sep 20, 2020
@reyhhan
Copy link
Contributor

reyhhan commented Sep 21, 2020

Could you please tell me which file contains the telephone number block?

@midzer
Copy link
Member Author

midzer commented Sep 21, 2020

Hi @ReyhanSara
Great that you want to have a look! 👍

In case you want to participate in https://hacktoberfest.digitalocean.com/, you can wait 9 more days for PR.

Here's the relevant line

{{ with $location.phone }}<li>Telefon: {{ . }}</li>{{ end }}

@reyhhan
Copy link
Contributor

reyhhan commented Sep 21, 2020

Yes, I'm looking forward to participate and this is my first time.
Will have a look at it. Thank you!

@reyhhan
Copy link
Contributor

reyhhan commented Sep 22, 2020

Hi. I'm trying to view the output of the file on Chrome and all I see is the source code. Appreciate if you can guide me on this.

@midzer
Copy link
Member Author

midzer commented Sep 22, 2020

@ReyhanSara Sorry, this repository is lacking a proper README.md. I will write one the next days.

Basically, this is a https://gohugo.io/ theme. It is included as a submodule for one of the other data repositories in this organisation. Let's see how far you can go with this info or wait until I've written a Setup guide.

@reyhhan
Copy link
Contributor

reyhhan commented Sep 22, 2020

oh okay. Now that I have this information I shall do a research on it and see what I can do till then.

@midzer midzer mentioned this issue Sep 24, 2020
@reyhhan
Copy link
Contributor

reyhhan commented Oct 1, 2020

Hi there. I just fixed the telephone link issue. I hope it's correct.

reyhhan added a commit to reyhhan/ln-base that referenced this issue Oct 8, 2020
@midzer
Copy link
Member Author

midzer commented Oct 28, 2020

Closing now as I've merged #18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest
Projects
None yet
Development

No branches or pull requests

2 participants