fix: improve extraction rules

lokalise · Jul 28, 2021 · 5850694 · 5850694
1 parent 67251a8
commit 5850694
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/src/extraction/rules/basic.ts b/src/extraction/rules/basic.ts
@@ -17,17 +17,20 @@ export class BasicExtrationRule extends ExtractionRule {
     // ❌ camel case
     if (s.match(/[a-z][A-Z0-9]/))
       return ExtractionScore.ShouldExclude
-    // ❌ all small cases
+    // ❌ all lower cases
     if (s.match(/^[a-z0-9-]+$/))
       return ExtractionScore.ShouldExclude
+    // ❌ all upper cases
+    if (s.match(/^[A-Z0-9-]+$/))
+      return ExtractionScore.ShouldExclude
     // ❌ all digits
     if (s.match(/^[\d.]+$/))
       return ExtractionScore.ShouldExclude
     // ✅ all words
     if (s.match(/^[A-Za-z0-9]+$/))
       return ExtractionScore.ShouldInclude
     // ✅ one char
-    if (s.length === 1 && !'/.-\\:+$^#,'.includes(s))
+    if (s.length === 1 && !'/.-\\:+$^#_"\','.includes(s))
       return ExtractionScore.ShouldInclude
   }
 }