feat: add a number of detected hardcoded strings in tree view, close #…

…633

.vscode/settings.json

@@ -48,7 +48,8 @@
   ],
   "i18n-ally.enabledFrameworks": [
     "vscode",
-    "vue"
+    "vue",
+    "general"
   ],
   "i18n-ally.theme.annotationMissingBorder": "#d37070",
   "i18n-ally.theme.annotationMissing": "#d37070",

locales/en.json

@@ -209,6 +209,7 @@
   "review.unknown_user": "Unknown",
   "view.current_file": "Current file",
   "view.current_file_hard_strings": "Hard-coded strings [beta]",
+  "view.current_file_hard_strings_expand_to_detect": "(Expand to detect)",
   "view.current_file_hard_strings_not_supported": "\"{0}\" is not supported yet",
   "view.current_file_keys_in_use": "Keys in use",
   "view.current_file_keys_not_found": "Keys not found",

src/editor/reviewComments.ts

@@ -1,4 +1,4 @@
-import { comments, CommentController, TextDocument, CancellationToken, Range, Disposable, commands, CommentReply, CommentAuthorInformation, Uri, Comment, MarkdownString, CommentMode, CommentThread } from 'vscode'
+import { comments, CommentController, TextDocument, Range, Disposable, commands, CommentReply, CommentAuthorInformation, Uri, Comment, MarkdownString, CommentMode, CommentThread } from 'vscode'
 import { EXT_REVIEW_ID } from '../meta'
 import { getAvatarFromEmail } from '../utils/shared'
 import { ExtensionModule } from '~/modules'
@@ -141,7 +141,7 @@ class ReviewCommentProvider implements Disposable {
     return Global.enabledParsers.filter(p => p.annotationSupported)
   }
 
-  async provideCommentingRanges(document: TextDocument, token: CancellationToken): Promise<Range[]> {
+  async provideCommentingRanges(document: TextDocument): Promise<Range[]> {
     const filepath = document.uri.fsPath
 
     if (this._threads[filepath]) {

src/editor/statusbar.ts

@@ -4,7 +4,7 @@ import { ExtensionModule } from '~/modules'
 import { Config, Global, CurrentFile } from '~/core'
 import i18n from '~/i18n'
 
-const statusbar: ExtensionModule = (ctx) => {
+const statusbar: ExtensionModule = () => {
   const disposables: Disposable[] = []
   const priority = -1000
   const bar1 = window.createStatusBarItem(StatusBarAlignment.Right, priority + 1)

src/env.ts

@@ -1,5 +1,5 @@
 // @ts-ignore
-export const isProd: boolean = process.env.NODE_ENV === 'production' 
-export const isDev: boolean = !isProd
+export const isProd: boolean = process.env.NODE_ENV === 'production'
+export const isDev = !isProd
 // @ts-ignore
-export const isTest: boolean = process.env.NODE_ENV === 'test' 
+export const isTest: boolean = process.env.NODE_ENV === 'test'

src/extraction/rules/base.ts

@@ -9,6 +9,7 @@ export enum ExtractionScore {
 export abstract class ExtractionRule {
   abstract name: string
 
+  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   shouldExtract(str: string): ExtractionScore | void {
     return ExtractionScore.None
   }

src/parsers/json5.ts

@@ -15,7 +15,7 @@ export class Json5Parser extends Parser {
     return JSON5.parse(text)
   }
 
-  async dump(object: object, sort: boolean) {
+  async dump(object: object) {
     return JSON5.stringify(object, {
       space: this.options.tab === '\t' ? this.options.tab : this.options.indent,
     })

src/parsers/php.ts

@@ -18,7 +18,7 @@ export class PhpParser extends Parser {
     return parser.parse(text)
   }
 
-  async dump(object: object, sort: boolean) {
+  async dump() {
     return ''
   }
 }

src/tagSystems/base.ts

@@ -13,6 +13,7 @@ export abstract class BaseTagSystem {
     return bcp47
   }
 
+  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   toFlagname(locale: string): string | undefined {
     return undefined
   }

src/tagSystems/none.ts

@@ -4,7 +4,7 @@ import { BCP47 } from './bcp47'
 // but do nothing on normalization
 export class NoneTagSystem extends BCP47 {
   // no convertsion
-  normalize(locale?: string, fallback = 'en', strict = false) {
+  normalize(locale?: string, fallback = 'en') {
     return locale || fallback
   }
 }

src/views/items/CurrentFileExtractionItem.ts

@@ -23,25 +23,34 @@ export class CurrentFileExtractionItem extends BaseTreeItem {
     else {
       this.collapsibleState = TreeItemCollapsibleState.None
     }
-    this.updateDescription()
   }
 
   getLabel() {
     return i18n.t('view.current_file_hard_strings')
   }
 
-  updateDescription() {
+  // @ts-expect-error
+  get description() {
     if (this.collapsibleState === TreeItemCollapsibleState.None) {
-      this.iconPath = this.getIcon('symbol-string-gray')
-      this.description = i18n.t('view.current_file_hard_strings_not_supported', this.langId)
+      return i18n.t('view.current_file_hard_strings_not_supported', this.langId)
     }
     else {
-      this.iconPath = this.getIcon('symbol-string')
       const length = CurrentFile.hardStrings?.length
-      this.description = length == null ? '' : length.toString()
+      if (this.collapsibleState === TreeItemCollapsibleState.Collapsed && !length)
+        return i18n.t('view.current_file_hard_strings_expand_to_detect')
+      else
+        return length == null ? '' : length.toString()
     }
   }
 
+  // @ts-expect-error
+  get iconPath() {
+    if (this.collapsibleState === TreeItemCollapsibleState.None)
+      return this.getIcon('symbol-string-gray')
+    else
+      return this.getIcon('symbol-string')
+  }
+
   async getChildren() {
     if (this.collapsibleState === TreeItemCollapsibleState.None)
       return []

src/views/providers/CurrentFileLocalesTreeProvider.ts

@@ -21,6 +21,7 @@ export class CurrentFileLocalesTreeProvider implements TreeDataProvider<BaseTree
     this.loadCurrentDocument()
 
     CurrentFile.onInvalidate(() => this.loadCurrentDocument())
+    CurrentFile.onHardStringDetected(() => this.refresh())
   }
 
   getTreeItem(element: BaseTreeItem): TreeItem {

src/views/providers/HelpFeedbackProvider.ts

@@ -1,7 +1,7 @@
 import { TreeItem, ExtensionContext, TreeDataProvider, Command } from 'vscode'
-import { Commands } from '../../commands'
-import Links from '../../links'
 import { FeedbackItem } from '../items/FeedbackItem'
+import Links from '~/links'
+import { Commands } from '~/commands'
 import i18n from '~/i18n'
 
 export interface FeedbackItemDefintion {

src/views/providers/LocalesTreeProvider.ts

@@ -1,9 +1,9 @@
 import { TreeItem, ExtensionContext, TreeDataProvider, EventEmitter, Event } from 'vscode'
 import { sortBy, throttle } from 'lodash'
-import { resolveFlattenRootKeypath } from '~/utils'
 import { LocaleTreeItem } from '../items/LocaleTreeItem'
 import { EditorPanel } from '../../webview/panel'
 import { THROTTLE_DELAY } from '../../meta'
+import { resolveFlattenRootKeypath } from '~/utils'
 import { Node, Loader, CurrentFile, LocaleTree, LocaleNode } from '~/core'
 
 export class LocalesTreeProvider implements TreeDataProvider<LocaleTreeItem> {