Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Set other root path. #120

Closed
DaniGTA opened this issue Nov 26, 2019 · 3 comments
Closed

[Feature Request] Set other root path. #120

DaniGTA opened this issue Nov 26, 2019 · 3 comments
Labels

Comments

@DaniGTA
Copy link

DaniGTA commented Nov 26, 2019

The 'package.json' is not in the root path of my project.

Additional context
Error msg:

Error on parsing package.json
⚠ Current workspace is not a valid project, extension disabled

Solution:
Let me set the root path to the angular project.
like:

"i18n-ally.projectRootPath": "folder/folder/folder",

@antfu
Copy link
Contributor

antfu commented Nov 26, 2019

Hi @DaniGTA. For now, package.json is only used to detect which frameworks you are using. In the future, we may not only support node frameworks (which are not relying on package.json). I would definitely consider how to implement this customization properly.

For now, to make it works for your project, all you need to make the setting

"i18n-ally.enabledFrameworks": "ngx-translate"

Hope this helps.

@antfu antfu changed the title [Framework Request] Set other root path. [Feature Request] Set other root path. Nov 26, 2019
@DaniGTA
Copy link
Author

DaniGTA commented Nov 27, 2019

It works now thanks.

@antfu
Copy link
Contributor

antfu commented Dec 6, 2019

Closing this for now. For now, this problem can be solved easily by the config. I would update the docs as well.

If you have any questions, feel free to reopen it.

@antfu antfu closed this as completed Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants