Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flag for "vi" is wrong #498

Closed
MuTsunTsai opened this issue Mar 7, 2021 · 2 comments
Closed

Flag for "vi" is wrong #498

MuTsunTsai opened this issue Mar 7, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@MuTsunTsai
Copy link

MuTsunTsai commented Mar 7, 2021

Describe the bug
This is similar to issue #489, and this time the flag for locale "vi" is displayed as that of U.S. Virgin Islands but it should have been the flag of Vietnam instead (it will correctly show Vietnam if the "vi-VN" is specified though).

Extension Version
i18n Ally v2.5.3

Screenshots
image

@MuTsunTsai MuTsunTsai added the bug Something isn't working label Mar 7, 2021
@antfu
Copy link
Contributor

antfu commented Mar 7, 2021

We have these flags:

https://github.com/lokalise/i18n-ally/blob/master/res/flags/vn.svg
https://github.com/lokalise/i18n-ally/blob/master/res/flags/vi.svg

It might be confused with the county code and locale code, what's your suggestion here?

Maybe we should add an entry to this with 'vi': 'vn'?

i18n-ally/src/meta.ts

Lines 25 to 32 in ff6f406

export const DEFAULT_LOCALE_COUNTRY_MAP = {
en: 'us',
zh: 'cn',
de: 'de',
fr: 'fr',
ja: 'ja',
es: 'es',
}

@MuTsunTsai
Copy link
Author

Yes, I would say that's the way to go. And you guys might also want to generalize it to more locale codes as well.

@antfu antfu closed this as completed in 6d0aab1 Mar 7, 2021
@antfu antfu added this to the Weekly cycle 002 milestone Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

2 participants