Add json5 support

[guyaumetremblay]

Hi,

We use .json5 in our project to enable the use of comments in locales files.

Is it possible to add the support of this extension please?

Thanks in advance.

[antfu]

@guyaumetremblay Hi, I would love to do that.

But I am not sure is there a way to keep comments on json5.stringify. If it can't, should we disable the editing / translating features in this extension for json5?

[antfu]

@guyaumetremblay JSON5 supporting is landed from v0.27.0 🎉

As I mentioned above, stringify won't be able to keep the comments. You may want to set this extension to readonly mode by:

"vue-i18n-ally.readonly": true

For more details please refer to https://github.com/antfu/vue-i18n-ally#comments-in-yamljson5

[guyaumetremblay]

Yes, that's sad. I just saw this issue on the JSON5 repo about keeping the comments: json5/json5#177

TLDR : the v3 of json5 will probably fix this.

About your update, I'm going to test this right now! Thanks for your fast update!

[guyaumetremblay]

Hi again,

The new version is working as expected (in readonly as mentioned).

Thank you again! We'll follow the v3 of JSON5!

[antfu]

I would also check out how vscode handles its setting jsons (it supports comments and preserves comments) when I got free time. 😁

[guyaumetremblay]

Yep that's right!
You can re-open this issue as a reminder if you want ;)

[antfu]

@guyaumetremblay Hi. I have found the parser vscode used to handle their settings.json and I opened another issue(#61) to support it.

Just as a reference, It's it possible for your project to adapt to JSONC or is there some other features in JSON5 are necessary to you? Thanks

[guyaumetremblay]

@antfu Sorry but I can take this decision, neither propose to move from json5 to jsonc only for a VSCode plugin. Their is 30 developers working on this project at my client side and their is only a few who use vscode :(