Fixing byte compilation issues #42
Conversation
|
Thanks. This sounds like a good idea. At least until I can get the copyright assignments done so that it can be posted to ELPA. I'll take a look at your proposed changes. |
|
ELPA is always preferable, but I am not sure what the state if of the other contributors with significant contributions (@fourier, @doyougnu, @ecraven). It might be manageable, but if for whatever reason it wouldn't be, I think it would be preferable to just add the package to NonGNU ELPA, that doesn't require any CA. |
|
Yes, that's why I think it's a good idea. I have no idea when the copyright assignments will be done. |
|
I have signed copyright papers and have code in ELPA if it helps. |
|
I'd prefer not to merge the changes as-is, since they change spaces to tabs. Can you recommit with only spaces? The commits themselves looks fine to me, but I might have missed something due to the noise caused by the spaces being changed to tabs. |
|
Sorry about that, should be fixed now. I also hope it is ok to add a .dir-locals.el to make sure that this doesn't happen again in the future. |
|
If you are interested, I could also add the Makefile I was using to the project. It could be used to set up a CI (though I don't know how GitHub does that). |
This primarily includes declaring various variables and functions, replacing outdated conventions (usage of interactive commands, outdated define-minor-mode usage) fixing a few docstrings and moving functions around to improve visibility.
I don't mind at all. Integrating with the github builds is very easy. |
|
Ok, as you see I have added the Makefile to this push request. I have no experience with GitHub Builds, so I hope you can take care of that. |
|
Thank you for merging the changes. In case you are still interested: All that is left for NonGNU ELPA would be to update the version tag, as indicated in the first message. |
|
Thanks. Done. |
Hi,
I would like to add gnu-apl-mode to NonGNU ELPA, but before that is done, a few code issues should be fixed. The attached patches improve remove the deprecated cl library, and fix a number of issues raised by the byte compiler (see commit description).
If you decide to apply these changes, it would be necessary to bump the version attribute in the main file, so that ELPA recognizes a new release with these improvements.