alt added to image overlay in js #365
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I need this, why isn't this merged yet? |
|
@gitaarik this is being merged into |
lokesh
force-pushed
the
master
branch
3 times, most recently
from
de83cee
to
c1c0f87
Compare
|
Cool thanks! |
|
@lokesh The transfer of the alt-tag still seems (or maybe again) not to be working. Also on your homepage http://lokeshdhakar.com/projects/lightbox2/ the alt tag is not displayed correctly. There the alt-tag displays the src link. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The alt tag is fine with the images (normal state) but when you click on the image and the overlay is displayed, the image doesn't have an alt tag. I've solved the issue now. Kindly check. Thanks.