cn_turtle_hash: Use the light flag in portable implementation #1126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doy-lee
force-pushed
the
CNTurtleHashSoftwareFix
branch
3 times, most recently
from
be232ce
to
ee2434f
Compare
Doy-lee
force-pushed
the
CNTurtleHashSoftwareFix
branch
from
ee2434f
to
a763d4f
Compare
inconsistent results. I desk checked against the ARM64 implementation that does NOT used the +crypto extensions, meaning it is emulated in software- That implementation is essentially the same as the portable implementation, some minor differences in the pre-amble but correctly uses the light flag. Adapting that over allows us to sync past block 321280, which previously emitted an "unexpected difficulty" error. This code path was never excercised due to the '-maes' flag being forced on via CMake. That was removed in this commit to make it specifiable by the user. oxen-io@17be0ed
Doy-lee
force-pushed
the
CNTurtleHashSoftwareFix
branch
from
a763d4f
to
7960cc4
Compare
jagerman
approved these changes
Apr 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The portable implementation doesn't use the light parameter causing
inconsistent results. Desk checking against the ARM64 implementation
that does NOT used the +crypto extensions, meaning it is emulated in
software- That implementation is essentially the same as the portable
implementation, some minor differences in the pre-amble but correctly
uses the light flag.
Adapting that over allows us to sync past block 321280, which previously
emitted an "unexpected difficulty" error and has also been tested to sync
all the blocks in hardfork 11 which use cn turtle successfully.
This code path was never excercised due to the '-maes' flag being forced
on via CMake. That was removed in this commit to make it specifiable by
the user.
17be0ed