AES changes backport to stable #1192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inconsistent results. I desk checked against the ARM64 implementation that does NOT used the +crypto extensions, meaning it is emulated in software- That implementation is essentially the same as the portable implementation, some minor differences in the pre-amble but correctly uses the light flag. Adapting that over allows us to sync past block 321280, which previously emitted an "unexpected difficulty" error. This code path was never excercised due to the '-maes' flag being forced on via CMake. That was removed in this commit to make it specifiable by the user. oxen-io@17be0ed
Force aes instruction availability in the pico & heavy implementations; they each have runtime checks that will ensure they are supported before called, and so this allows creating a binary that supports both non-AES and AES CPUs. This also unifies some of the common cpuid checking code, and moves it to a single global variable (previously pico used a somewhat inefficient static local variable, and cn-heavy used a hugely inefficiently cpuid call on every hash call). Also removes the x86-specific __m128i code from cn_heavy_hash.hpp and adds a simple wrapper for it in the intel-specific code instead.
Fix inverted logic, and rename it to something more descriptive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #1126 and #1191 to master.
The current debs on focal and sid can't sync through the cn-pico section of the chain because gcc 9.x no longer implies -maes for anything earlier than -march=skylake because some CPUs in generations before Skylake don't have it turned on.
With these changes:
(Obligatory rant: this is a result of Intel's bullshit of turning off CPU features on things below i7 for marketing reasons -- expensive Intel products get new instructions turned on, but cheap Intel products have to wait an incredible SIX generations before Intel actual enables the feature, despite being supported in the silicon).