Merge upstream ~(130 commits) #1149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sfers And add them for pending transfers, where they were missing
>N limits display to alt chains with more than N blocks -N limits display to alt chains younger than N blocks
Exceptions would otherwise terminate the process silently
We might have external access without having to do this
It would try to get their prunable hash, but v1 txes don't have one
In static member function ‘static boost::optional<cryptonote::rpc::output_distribution_data> cryptonote::rpc::RpcHandler::get_output_distribution(const std::function<bool(long unsigned int, long unsigned int, long unsigned int, long unsigned int&, std::vector<long unsigned int>&, long unsigned int&)>&, uint64_t, uint64_t, uint64_t, const std::function<crypto::hash(long unsigned int)>&, bool, uint64_t)’: cc1plus: warning: ‘void* __builtin_memset(void*, int, long unsigned int)’: specified size 18446744073709551536 exceeds maximum object size 9223372036854775807 [-Wstringop-overflow=]
In that case, we'll still keep the "Monero is now disconnected from the network" near the end of the log
Make bans control RPC sessions too. And auto-ban some bad requests. Drops HTTP connections whenever response code is 500.
This is an inherently probabilistic check, which occasionally fails for a matching distribution
The wallet was ignoring --restore-height and --restore-date params and prompting for them again.
- getTxKey method throws an exception, e.g., when user declines txKey export
find_package(PythonInterp) needs to be called before the tests.
"Exploring the Monero Peer-to-Peer Network". https://eprint.iacr.org/2019/411
This is likely to be done via a script
This reverts commit a182df2.
jagerman
approved these changes
Jun 3, 2020
| @@ -1234,6 +1234,7 @@ namespace cryptonote | |||
| if (tvc.m_double_spend) os << "Double spend TX, "; | |||
| if (tvc.m_invalid_input) os << "Invalid inputs, "; | |||
| if (tvc.m_invalid_output) os << "Invalid outputs, "; | |||
| if (tvc.m_too_few_outputs) os << "Need atleast 2 outputs, "; | |||
| @@ -157,6 +157,7 @@ static_assert(STAKING_PORTIONS % 12 == 0, "Use a multiple of twelve, so that it | |||
| #define HF_VERSION_ED25519_KEY cryptonote::network_version_13_enforce_checkpoints | |||
| #define HF_VERSION_FEE_BURNING cryptonote::network_version_14_blink | |||
| #define HF_VERSION_BLINK cryptonote::network_version_14_blink | |||
| #define HF_VERSION_MIN_2_OUTPUTS cryptonote::network_version_16 | |||
There was a problem hiding this comment.
I thought this was already enforced. Or is it just done by the wallet but not enforced?
There was a problem hiding this comment.
Just wallet, it would fail on construction, but if you tweak the wallet to allow it, like we do with LNS transactions then it goes through fine. (1 change output + tx extra burn fee).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.