Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JSON serialization of pulse block data #1286

Merged
merged 1 commit into from
Sep 27, 2020

Conversation

jagerman
Copy link
Member

There was a missing call to nested the values in an object, so the
resulting json ended up as:

"pulse":,"random_value":"b01b8d1290cbac40917a23a08b343bec","round":0,"validator_bitset":2047,

instead of:

"pulse":{"random_value":"b01b8d1290cbac40917a23a08b343bec","round":0,"validator_bitset":2047},

Modernize it to avoid macros, and fix it by beginning an object.

(This won't affect binary serialization; object serialization only has
an effect on json serialization and is a no-op for binary
serialization).

There was a missing call to nested the values in an object, so the
resulting json ended up as:

    "pulse":,"random_value":"b01b8d1290cbac40917a23a08b343bec","round":0,"validator_bitset":2047,

instead of:

    "pulse":{"random_value":"b01b8d1290cbac40917a23a08b343bec","round":0,"validator_bitset":2047},

Modernize it to avoid macros, and fix it by beginning an object.

(This won't affect binary serialization; object serialization only has
an effect on json serialization and is a no-op for binary
serialization).
@Doy-lee Doy-lee merged commit b608d60 into oxen-io:dev Sep 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants