-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clearnet p2p #317
Clearnet p2p #317
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a few little bits
@@ -535,9 +548,11 @@ | |||
window.log.info('Cleanup: complete'); | |||
|
|||
window.log.info('listening for registration events'); | |||
Whisper.events.on('registration_done', () => { | |||
Whisper.events.on('registration_done', async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whisper.events.on('registration_done', async () => { | |
Whisper.events.on('registration_done', () => { |
Un-needed async
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do in separate PR
nat-upnp
to punch hole. We try to read the existing mappings first, if that fails, we assume uPnP not enabled and we stop the server. If that works, we get the existing public ports in use. Then we try to punch from port 22100 to 22200, skipping the ports we know are already in use by other processes. After this, we can querynat-upnp
for the public ip that we need to broadcast.Coming next: signing with signal pubkey of SSL cert + verification