Add right click option to public chat messages to copy pubkey of sender #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sachaaaaa
reviewed
Aug 8, 2019
| if (this.isIncoming()) { | ||
| clipboard.writeText(this.get('source')); | ||
| } else { | ||
| clipboard.writeText(this.OUR_NUMBER); |
There was a problem hiding this comment.
What would the source be for a non-incoming message?
Asking to see if it's worth differentiating incoming/outgoing or no...
There was a problem hiding this comment.
It was undefined and was causing writeText to error
Come to think of it maybe I should double check the source is defined anyway
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add option to copy pubkey from public chat messages so you can easily add friends from the chat