Disable metrics by default #754
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-loki
reviewed
Aug 6, 2019
| { | ||
| disableMetrics = true; | ||
| disableMetrics = IsFalseValue(val); |
There was a problem hiding this comment.
I think if we’re doing it like this, we should rename the variable to enableMetrics
There was a problem hiding this comment.
i added an option for that too
There was a problem hiding this comment.
I mean, if metrics are disabled by default, we should make the variable “enableMetrics”, with a default value of false.
Positive bools are easier to understand imo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.