Windows build fixes #859
Closed
Windows build fixes #859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
despair86
reviewed
Oct 11, 2019
| @@ -24,7 +24,7 @@ if(NOT MSVC_VERSION) | |||
| add_definitions(-DWINVER=0x0500 -D_WIN32_WINNT=0x0500) | |||
| # Wait a minute, if we're not Microsoft C++, nor a Clang paired with Microsoft C++, | |||
| # then the only possible option has to be GNU or a GNU-linked Clang! | |||
| set(FS_LIB stdc++fs) | |||
| # set(FS_LIB stdc++fs) | |||
There was a problem hiding this comment.
Latest mingw ships with a non-broken stdlib
There was a problem hiding this comment.
ok apparently only mainstream targets get this special treatment (pretty much Linux/macOS/Windows)
t. builds on a bunch of niche, arcane, yet up to date platforms that still ship a separate c++17 filesystem ts lib even at GCC 9 (BSDs...)
There was a problem hiding this comment.
wrap it around a library check or version check at least
|
Merging, and reversing the patch listed above |
despair86
added a commit
to despair86/loki-network
that referenced
this pull request
Oct 30, 2019
despair86
added a commit
to despair86/loki-network
that referenced
this pull request
Oct 30, 2019
despair86
added a commit
to despair86/loki-network
that referenced
this pull request
Oct 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.