fully integrated windows package #864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
despair86
changed the title
majestrate
reviewed
Oct 14, 2019
despair86
force-pushed
the
dev
branch
6 times, most recently
from
8b0d7f9
to
b0177c3
Compare
majestrate
reviewed
Oct 17, 2019
despair86
force-pushed
the
dev
branch
3 times, most recently
from
026cd11
to
8232c42
Compare
despair86
force-pushed
the
dev
branch
2 times, most recently
from
a5689ac
to
1d08cef
Compare
|
ok if we merge this we can safely get rid of the vendored libsodium |
b. not my fault your machine doesn't link pthread properly
will finish testing this once the new release is stable
…c server remove dup rule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with everything and the kitchen sink
a. GCC LTO requires specifiying CXXFLAGS in LDFLAGS
b. not my fault your machine doesn't link pthread properly (What does this affect? Raspbian users?)
c. grab everything and the kitchen sink at installer build time
d. devendor libsodium from win32 by generating patchset to be applied to upstream
e. remove vendored libsodium