Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit test for command line parser #209

Merged
merged 1 commit into from
Jul 4, 2019
Merged

Unit test for command line parser #209

merged 1 commit into from
Jul 4, 2019

Conversation

sachaaaaa
Copy link
Contributor

  • Moved the git hash/timestamp execution form top-level CmakeLists to httpserver CmakeLists to prevent full recompile when running make
  • Build static lib with httpserver logic and link it against main and unit test
  • Moved logic (get_home_dir) out of command_line_parser (keep it dumb)
  • Add unit tests for command line parser

@BeaudanBrown BeaudanBrown merged commit e1258d9 into oxen-io:dev Jul 4, 2019
@sachaaaaa sachaaaaa deleted the unittest_cmdline branch July 5, 2019 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msgmaxim msgmaxim msgmaxim approved these changes

@BeaudanBrown BeaudanBrown BeaudanBrown approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sachaaaaa @msgmaxim @BeaudanBrown