Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

account for sentinel value for swarm id in pk mapping #28

Merged
merged 2 commits into from
Apr 2, 2019
Merged

account for sentinel value for swarm id in pk mapping #28

merged 2 commits into from
Apr 2, 2019

Conversation

msgmaxim
Copy link
Contributor

  • additionally we no longer assume that all_swarms is sorted

BeaudanBrown
BeaudanBrown reviewed Mar 28, 2019
View reviewed changes
httpserver/swarm.cpp Outdated Show resolved Hide resolved
sachaaaaa
sachaaaaa reviewed Mar 29, 2019
View reviewed changes
httpserver/swarm.cpp Outdated Show resolved Hide resolved
httpserver/swarm.cpp Outdated Show resolved Hide resolved
@msgmaxim
Copy link
Contributor Author

I rebased to fix the typo and a compilation error. The rest is the same as before.

sachaaaaa
sachaaaaa reviewed Mar 29, 2019
View reviewed changes
Copy link
Contributor

@sachaaaaa sachaaaaa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My final pedantic const round* :)
(*if applicable)

httpserver/swarm.cpp Outdated Show resolved Hide resolved
httpserver/swarm.cpp Outdated Show resolved Hide resolved
httpserver/swarm.cpp Outdated Show resolved Hide resolved
sachaaaaa
sachaaaaa approved these changes Mar 29, 2019
View reviewed changes
Copy link
Contributor

@sachaaaaa sachaaaaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@msgmaxim
Copy link
Contributor Author

msgmaxim commented Apr 1, 2019

Rebased to use Sacha's suggestion.

@BeaudanBrown BeaudanBrown merged commit 5d3078d into oxen-io:integration-dev Apr 2, 2019
@msgmaxim msgmaxim deleted the sentinel branch April 8, 2019 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sachaaaaa sachaaaaa sachaaaaa approved these changes

@BeaudanBrown BeaudanBrown BeaudanBrown approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@msgmaxim @sachaaaaa @BeaudanBrown