(Low priority) Add disabled-by-default quorum storage support #702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jagerman
changed the title
jagerman
force-pushed
the
quorum-state-storage
branch
from
10f83dd
to
3c08435
Compare
Doy-lee
reviewed
Jul 16, 2019
Doy-lee
approved these changes
Jul 17, 2019
msgmaxim
reviewed
Jul 17, 2019
This adds support for storing N blocks of recent expired quorum state history in lokid (and dumping to/from the lmdb). This isn't useful for regular nodes (and that's why we don't store it) but is incredibly useful for the block explorer to be able to report *which* node got deregistered/decommissioned/etc. by a given state_change tx.
jagerman
force-pushed
the
quorum-state-storage
branch
from
b8e546e
to
32a17df
Compare
jagerman
added a commit
to jagerman/loki
that referenced
this pull request
Jul 17, 2019
Doy-lee
pushed a commit
that referenced
this pull request
Jul 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for storing N blocks of recent expired quorum state
history in lokid (and dumping to/from the lmdb).
This isn't useful for regular nodes (and that's why we don't store it)
but is incredibly useful for the block explorer to be able to report
which node got deregistered/decommissioned/etc. by a given
state_change tx.
I'm not sure that we should necessarily worry about merging this for the 4.0.0 release, but it is very nice to have on the block explorer, for example to be able to see these details from a tx a day ago: https://tn.imaginary.stream/tx/009add352449842d8d99af736ff584e1a16574487675739355161f66a862d11a