Increase Photo Quality #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this really make much of a difference? I think the tradeoff for a bit lower quality is the decrease in file size, but the visual difference between 95 and 85 shouldn't be too much so it would be preferable to use the lower one to have lower file sizes. |
|
85 is pretty noticeable, it made it in to the issues list. If we really wanted to save the file size the better move would be to downsize the dimensions of the resultant bitmap rather than decrease the quality but there's nothing stopping people uploading full res pictures from their camera roll as it stands |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Increases the quality parameter for JPEG files which are generated using the camera button. Tested on Moto One Vision.