Displays proper url to open loklak_server during start and installation #1174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SKrPl error in travisCI build -> https://travis-ci.org/loklak/loklak_server/builds/233754489#L834 |
|
@vibhcool please check it now. Now the build is passing, last time it didn't because Travis couldn't download a gradle dependency, so the build didn't work. |
vibhcool
suggested changes
May 19, 2017
There was a problem hiding this comment.
[vibhcool@localhost loklak_server]$ bin/start.sh -p 8888
Loklak detected that you did not yet run the installation wizard.
It let's you setup an administrator account and a number of settings, but is not mandatory.
You can manually start it by running bin/installation.sh
starting loklak
bin/start.sh: line 94: [: =: unary operator expected
works fine, but see last line
|
@vibhcool done the required changes |
|
@SKrPl Please ask other co-developers and assign them when you make a PR always. We need several reviews before we can merge. Please help to make this flow work. |
daminisatya
reviewed
May 20, 2017
singhpratyush
approved these changes
May 20, 2017
Solves issue: #1172 Displays proper localhost url in which loklak_server is running after the execution of bin/start.sh or bin/installation.sh with a "p" flag. Earlier the localhost url only displayed port 9000 at the end in case of bin/start.sh and concatenated the running port with 9000 in case of bin/stop.sh.Ex: http://localhost:9000 # bin/start.sh, actual port 8888 http://localhost:90008888 #bin/installation.sh, actual port 8888
|
@daminisatya modified the commit message 😄 |
daminisatya
approved these changes
May 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves issue: #1172
Short description
I have:
Fixes #<number> commit messageFor the reviewers
I have: