Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds log4j2 as logging backend. We don't need to make any further adjustments to the code, it's a direct drop in and we can continue logging with
Log.getlog...
It's main benefit is the cache (by default 8KB), therefor reducing IO request significantly.
Especially on systems without ssds, this could improve performance alot.
It has also much more potential, like having a maximum filesize and gzipping of old logs, that we can enable later.
At some points in the loklak code, there's still direct prints (stacktraces for example) that don't use the log infrastructure yet. They're still logged to a new log file (stdout.log), but we can slowly move them all to using the log.
As this potentially impacts one-click deployments, I'd like to request help with testing them. Some of them probably expect us to write our log to stdout to be readable from their interface, so we might need to make adjustments on how we use them.
(scalingo for example has a log console. we have to check if the log is still written there)
Edit: scalingo, heroku and bluemix are now logging to console again as they did before. Docker cloud uses the logfile like before
Know issues: