Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTPS portability #724

Merged
merged 3 commits into from
Jul 20, 2016
Merged

HTTPS portability #724

merged 3 commits into from
Jul 20, 2016

Conversation

rmader
Copy link
Contributor

@rmader rmader commented Jul 20, 2016

This commit fixes a portability issue to platforms without openssl or "SUN" security provider.
It also simplifies the key conversion code.

Edit: the new library will probably also help on future work in other areas. For example support of curve25519-signatures, which are much more performant (faster and smaller key-sizes) than RSA. This is mostly interesting for IoT or embedded devices (where this is critical), but also could benefit peer-to-peer workloads.

With this patch, all key conversions are handled internally, instead of using openssl.
Also, other "SUN" is not the only supported security provider anymore.
@mariobehling
Copy link
Member

@treba123 Which issue is it related to?

@rmader
Copy link
Contributor Author

rmader commented Jul 20, 2016

@mariobehling Didn't open an issue before, just faced the problem myself and fixed it directly. Sorry if that is a problem.

The issue would be: use key-cert option on systems without openssl

@mariobehling
Copy link
Member

Thanks for the info. We had a number of cases where people worked on overlapping issues now - without creating an issue.

It might not be the case in your area, but it would make it much easier if we all follow best practices.

So, let's match every PR with an issue and provide some short description (which would make it hopefully easier and faster to review as well).

Thank you!

@rmader rmader merged commit b23bd71 into loklak:development Jul 20, 2016
@mariobehling
Copy link
Member

@treba123 Please ask someone to merge your PRs. I did not merge, because I am not into this topic. I think @shivenmian is involved usually. You could have asked him. We should follow peer-review practices.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants