Log all output to data/loklak.log #776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There should only be output from the console when the log-infrastructure fails. We can therefor write it into the same log file. This should it make easier for users to spot issues.
|
@daminisatya thank for the fast review :) did you start the server once with this change, just to check if anything unexpected happens? |
|
@treba123 Looks like no problems in the functionality. |
|
@sudheesh001 thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There should only be output from the console when the log-infrastructure fails. We can therefor write it into the same log file.
This should it make easier for users to spot issues.
(no issue for this, but there were multiple issues already where people didn't know about the second log file, for example #771)