Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added the required github templates, made the required template changes #866

Merged
merged 2 commits into from
Nov 14, 2016
Merged

Added the required github templates, made the required template changes #866

merged 2 commits into from
Nov 14, 2016

Conversation

sudheesh001
Copy link
Member

@sudheesh001 sudheesh001 commented Nov 14, 2016 •
edited by shivenmian

Short description

I have:

  • There is a corresponding issue for this pull request.
  • Mentioned the Issue number in the pull request commit message Fixes #<number> commit message
  • There is only strictly only one commit per issue.

For the reviewers

I have:

  • Reviewed this pull request by an authorized contributor.
  • The reviewer is assigned to the pull request.

@shivenmian shivenmian self-assigned this Nov 14, 2016
shivenmian
shivenmian approved these changes Nov 14, 2016
View reviewed changes
Copy link
Member

@shivenmian shivenmian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@shivenmian shivenmian merged commit 9a5973f into loklak:development Nov 14, 2016
@sudheesh001 sudheesh001 deleted the githubTemplates branch November 14, 2016 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shivenmian shivenmian shivenmian approved these changes

Assignees

@shivenmian shivenmian

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sudheesh001 @shivenmian