New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented: Support for static cache delay to cronjob feature #20

Merged
merged 1 commit into from Sep 22, 2014

Conversation

Projects
None yet
2 participants
@brookinsconsulting
Copy link
Contributor

brookinsconsulting commented Sep 22, 2014

Hello,

First, Thank you for such a wonderful extension as sqliimport. We love working with your extension!

The problem

We recently implemented static cache support for a site and found that content imported with sqliimport did not get static cache created when clearing the view cache via the 'sqliimport_cleanup' cronjob.

After some research we found that static cache was not being created because we use the staticcache.ini:[CacheSettings] CronjobCacheClear=enabled setting AND because when 'sqliimport_cleanup' cronjob runs to clear the view cache it did not include support for actually storing the requests for static cache updates in the ezpending_actions table because it lacks a call to 'eZStaticCache::executeActions()' function which does this work.

The solution

The solution to the above problem was to add a line of code used by the 'sqliimport_cleanup' cronjob part to call 'eZStaticCache::executeActions()' function which stores delayed requests to update static cache. Without this change the requests to delay static cache updates are never stored and thus never able to performed. For us this was a big negative feature creating a gaping hole in our otherwise perfect static cache setup.

Closing

Please review this pull request.

This change makes it possible for us to continue to sqliimport extension and CronjobCacheClear=enabled setting and we would really appreciate it if we did not have to maintain a patch to this extension in a fork.

Please let us know what you think.

Thank you for your continued support!

Cheers,
Brookins Consulting

lolautruche added a commit that referenced this pull request Sep 22, 2014

Merge pull request #20 from brookinsconsulting/staticcache-delay-to-c…
…ronjob-support

Implemented: Support for static cache delay to cronjob feature

@lolautruche lolautruche merged commit c4ba755 into lolautruche:master Sep 22, 2014

@lolautruche

This comment has been minimized.

Copy link
Owner

lolautruche commented Sep 22, 2014

Thanks for your contribution @brookinsconsulting !

@lolautruche

This comment has been minimized.

Copy link
Owner

lolautruche commented Sep 22, 2014

Just released v1.2.4 containing your patch :-)

@brookinsconsulting

This comment has been minimized.

Copy link
Contributor Author

brookinsconsulting commented Sep 23, 2014

Hello @lolautruche

Thank you very much for accepting my improvement.
Congratulations on the new v1.2.4 release!

Cheers,
Brookins Consulting

@brookinsconsulting brookinsconsulting deleted the brookinsconsulting:staticcache-delay-to-cronjob-support branch Sep 23, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment