Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github for mac gui #239

Closed
nwtn opened this issue Nov 19, 2014 · 4 comments
Closed

github for mac gui #239

nwtn opened this issue Nov 19, 2014 · 4 comments
Assignees
Labels

Comments

@nwtn
Copy link

nwtn commented Nov 19, 2014

I can't get lolcommits to work using Github for Mac GUI (192) on Yosemite. I've checked out other issue threads with similar problems (#104, #84, #71, and #27) and none of the solutions there worked for me. lolcommits works fine from the CLI. I've tried:

  • ln -s which lolcommits /usr/local/bin/lolcommits
  • sudo gem install lolcommits (to update to the latest version)
  • lolcommits --disable followed by lolcommits --enable

Any suggestions?

Thanks

@matthutchinson
Copy link
Member

Thanks for reporting this.

It turns out (after some lengthy investigation) that ASCII encoding is an issue with Yosemite, the GiHub for mac app and the git gem version we use. Out of the box, the gem fails to parse the git commit logs and throws a ASCII encoding error in Ruby (which silently gets swallowed by the post commit hook script.)

I'm going to issue a fix for this now, and release a new version of the gem (0.5.6) with some other improvements ASAP.

@matthutchinson
Copy link
Member

Ok, can you try this;

First find out what your current LANG env variable is on the command line with;

echo $LANG

Then change the commit hook (at /path/to/repo/.git/hooks/post-commit) to have the following line before the PATH export;

export LANG="en_US.UTF-8"

Then exit GitHub for mac, relaunch and try a commit?

@nwtn
Copy link
Author

nwtn commented Nov 21, 2014

Yup, that worked! Thanks!

@matthutchinson
Copy link
Member

v0.5.6 is out now, which should solve this issue. If you upgrade, don't forget to disable and re-enable lolcommits in your repositories to get the fixed post-commit hook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants