Replace http with https in twitter plugin. #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
http requests produce a 403 error during OAuth.
|
Did you perhaps for from an unstable branch? I can't see why your changes would have failed the CI build. |
|
I was wondering about that. I cloned straight from master; is that not stable? If not I can make a pull request from a different branch. |
|
It looks like it only failed on 1.9.3, on a completely unrelated test to this change. TravisCI has been pretty unreliable lately for some reason. I've restarted that job to see if it passes this time. |
|
Okay, great thanks! |
|
Looks good. |
mroth
added a commit
that referenced
this pull request
Feb 13, 2014
Replace http with https in twitter plugin.
|
@kleinschmidt 👍 thanks for fixing this |
|
released just now, in v0.5.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http requests produce a 403 error during OAuth.