Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable local plugins #250

Merged
merged 2 commits into from
Feb 9, 2015
Merged

enable local plugins #250

merged 2 commits into from
Feb 9, 2015

Conversation

salzig
Copy link
Contributor

@salzig salzig commented Feb 3, 2015

This change will allow you to place plugins into $LOLCOMMITS_DIR/.plugins (typically: ~/.lolcommits/.plugins) for experimentation or to use plugins that are not yet merged into lolcommits.

Every plugin placed into $LOLCOMMITS_DIR/.plugins has to implement the same interface as plugins shipped with lolcommits.

@salzig
Copy link
Contributor Author

salzig commented Feb 3, 2015

fixes: #99

@matthutchinson
Copy link
Member

This looks good to me, and a nice approach to help move our existing plugins into separate gems (and experimenting with new ones).

I don't think we should close out issue #99 just yet, since we'd like to see some of the existing plugins as gems, and have them auto-loaded if they are installed, not just from this new .lolcommits/.plugins dir.

@mroth if you think this OK too, please merge away.

@mroth
Copy link
Member

mroth commented Feb 9, 2015

Agreed, this could be helpful as we move towards #99, but definitely shouldn't supplant it.

It's unfortunate that as far as I can tell there is no equivalent of npm link in the ruby gems world, otherwise I would say this PR would be obsolete once we implement #99 as the proper packaging method for third-party plugins, but given there isn't something simple like that, this could definitely aide development for plugin makers then without them having to constantly do gem install --local while developing.

@mroth
Copy link
Member

mroth commented Feb 9, 2015

Thanks @salzig ! Merging now.

mroth added a commit that referenced this pull request Feb 9, 2015
@mroth mroth merged commit a04c86b into lolcommits:master Feb 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants