Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CodeClimate and simplecov for coverage reports #367

Merged
merged 1 commit into from
Feb 20, 2018

Conversation

matthutchinson
Copy link
Member

@matthutchinson matthutchinson commented Feb 19, 2018

Removes the coveralls gem and sets up simplecov to report on our unit test coverage to CodeClimate (35% we don't have much at all, but its a start 馃槃)

Right now, we use coveralls for this, but we can have code analysis all in one place at CodeClimate, and remove a gem in the process.

We only see coverage for our unit tests, since Aruba runs test commands in sub-processes, it is not possible gain coverage info from there.

Before this can be merged I need to add a CodeClimate coverage token to .travis.yml

@mroth - can you let me know what this token is? (its ok for it to be public)... I don't have access to grab it from their dashboard (see screenshots below).

screen shot 2018-02-18 at 21 45 16

screen shot 2018-02-18 at 21 45 25

@mroth
Copy link
Member

mroth commented Feb 19, 2018

@matthutchinson Grabbed it -- I'll email it to you just in case there's some reason we don't want it on GitHub (unfortunately there doesn't seem to be a way to add additional admins to a project on the free OSS version of CodeClimate?).

@matthutchinson
Copy link
Member Author

Thanks, I've added the token now, merging 馃憤

@matthutchinson matthutchinson merged commit 7a9f9a6 into master Feb 20, 2018
@matthutchinson matthutchinson deleted the use-code-climate-simplecov branch February 20, 2018 10:36
@matthutchinson
Copy link
Member Author

Coverage now available here: https://codeclimate.com/github/mroth/lolcommits/test_coverage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants