Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make the project run and compile #1

Merged
merged 1 commit into from
Apr 7, 2021

Conversation

belaczek
Copy link

Hi, I saw your PR seek-oss#218 and decides to try moving it forward a bit.

  • type and lint errors should be all fixed
  • webpack-dev-server was downgraded back to v3 as this version is already compatible with webpack 5. The v4 doesn't seem to be ready yet

I tried to run various scripts and all seem to be ok.

- fix lint and type errors
- downgrade webpack-dev-server
@loliver
Copy link
Owner

loliver commented Apr 6, 2021

Thanks for looking at this, is webpack-dev-server@4.x.x not needed for webpack@5.x.x? It's obviously been awhile since I've been tinkering with this so can't remember what order I tried various things in. Apologies for the delay in reply, we don't have any urgent reason to get Webpack 5 in to production and the areas I'm using it in are all for component documentation for our design system so are not high priority.

@belaczek
Copy link
Author

belaczek commented Apr 6, 2021

Hi, no worries. Yes, webpack-dev-server@3 is fully compatible with webpack@5. The v4 of dev server is still in beta.
I think it would make sense to merge my changes into your branch to make sure your PR passes lint checks and somebody else then could continue from that point.
In meantime, I have re-published my own webpack@5 compatible version of the playroom package so I'm currently also not in any urgency pushing the PR forward.

@loliver
Copy link
Owner

loliver commented Apr 7, 2021

Oh great, I think the lack of node 8 compatibility was a sticking point that contributed to me giving up at the time.

@loliver loliver merged commit 4ea2701 into loliver:upgrade-to-webpack-5 Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants