Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jumps of unstyled content and test freezes from display none #44

Closed
lolmaus opened this issue Mar 25, 2022 · 0 comments
Closed

Jumps of unstyled content and test freezes from display none #44

lolmaus opened this issue Mar 25, 2022 · 0 comments
Labels
bug

Comments

@lolmaus
Copy link
Owner

lolmaus commented Mar 25, 2022

  1. When an element query element initially renders, it appears unstyled.
  2. When display: none is applied to an element query element or any of its parents, Ember tests would pause forever because of ember-element-query test waiter.

Both issues are caused by the fact that the initial applying of element queries is asynchronous and channeled through ResizeObserver. Running the initial applying synchronously should fix them.

Details discovered by @simonihmig.
@lolmaus lolmaus added the bug label Mar 25, 2022
@lolmaus lolmaus mentioned this issue Mar 25, 2022
Merged
lolmaus added a commit that referenced this issue Mar 27, 2022
@lolmaus
Fix jumps of unstyled content and test freezes, credit to @simonihmig, …
5c8d49d 
…fixes #44: address PR feedback
lolmaus added a commit that referenced this issue Mar 29, 2022
@lolmaus
Fix jumps of unstyled content and test freezes, credit to @simonihmig, …
580faf5 
…fixes #44: address PR feedback
lolmaus added a commit that referenced this issue Mar 29, 2022
@lolmaus
Fix jumps of unstyled content and test freezes, credit to @simonihmig, …
d320b7d 
…fixes #44: update ember-auto-import for tests
lolmaus added a commit that referenced this issue Mar 29, 2022
@lolmaus
Fix jumps of unstyled content and test freezes, credit to @simonihmig, …
acaf7bf 
…fixes #44: include webpack to fix tests
lolmaus added a commit that referenced this issue Mar 29, 2022
@lolmaus
Merge pull request #45 from lolmaus/issue-44-jumps-and-freezes
36a04b0 
Fix jumps of unstyled content and test freezes, credit to @simonihmig, fixes #44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lolmaus