Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stripe sdk version support #8

Open
lolmx opened this issue Sep 21, 2019 · 1 comment
Open

Stripe sdk version support #8

lolmx opened this issue Sep 21, 2019 · 1 comment

Comments

@lolmx
Copy link
Owner

lolmx commented Sep 21, 2019

Issue: breaking changes over major sdk releases

As stated in this and this comments through #4, Stripe v7 introduced two main BC:

  • __toArray() became toArray()
  • all exceptions have been renamed

We need to support both versions as far as possible.
At the moment i see two ways to supports both, we can add a new config parameter to ask for used sdk version which i'm not fan or add checks with class_exists and method_exists.
I need more inputs to see how we can properly supports both versions.

This also raise the question about supporting older versions ^3|^4|^5. Are they still needed? Anyone in need to use Strong Customer Authentication already must use Stripe ^6.9 to have access to newer api (PaymentIntent & SetupIntent for js gateway).
New Checkout Server Flow (#6) also requires new apis available in ^6.

Wouldn't be beneficial to drop support for ^3|^4|^5? And also maybe for versions >=6.0 <6.9?

@diimpp
Copy link

diimpp commented Sep 23, 2019

Dropping Legacy Checkout seems to be a right solution, if we will maintain a separate fork from Payum (Or new major version payum/stripe:2.0). Otherwise we will need to accommodate old sdk and old gateway as well as new ones. Legacy Charge API is still functional and for example USA is exempt from SCA requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants