Implement initial Stripe Checkout Server flow #6
Conversation
| */ | ||
| protected function populateConfig(ArrayObject $config) | ||
| { | ||
| if (false === class_exists(Stripe::class)) { |
There was a problem hiding this comment.
It's better to check for PaymentIntent::class because this class has been added on 6.9 thus we force the minimal version.
Stripe::class is about to check if sdk is installed
There was a problem hiding this comment.
Stripe has const VERSION = '6.40.0'; so ultimately we should check against it. (Or at least I hope it appeared in earlier versions than 6.40).
| return; | ||
| } | ||
|
|
||
| if ($model['object'] === PaymentIntent::OBJECT_NAME && Constants::STATUS_REQUIRES_PAYMENT_METHOD == $model['status']) { |
There was a problem hiding this comment.
if i'm not wrong Constants::STATUS_REQUIRES_PAYMENT_METHOD == $model['status'] when the authentication failed and customer needs to enter a new card, and Constants::STATUS_REQUIRES_ACTION == $model['status'] when it's okay but need authentication?
There was a problem hiding this comment.
Good point, I'm kind of torn between requires_capture and requires_confirmation. It seem that requires_action is in-between state and authorized payment intent will have a requires_capture state.
If the selected payment method requires additional authentication steps, the PaymentIntent will transition to the
requires_actionstatus and suggest additional actions via next_action. If payment fails, the PaymentIntent will transition to therequires_payment_methodstatus. If payment succeeds, the PaymentIntent will transition to thesucceededstatus (orrequires_capture, if capture_method is set to manual).
https://stripe.com/docs/api/payment_intents/confirm
| ], $config['payum.paths'] ?: []); | ||
| } | ||
|
|
||
| protected function parseStripeVersion(string $version): array |
There was a problem hiding this comment.
@lolmx I cannot think of more elegant solution right now. A solution to 6.9/7.0 difference can be to make this method public and static and check in all actions for current version.
No description provided.