Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tranformWrite follow-ups #1784

Open
lolopinto opened this issue Mar 2, 2024 · 1 comment
Open

tranformWrite follow-ups #1784

lolopinto opened this issue Mar 2, 2024 · 1 comment

Comments

@lolopinto
Copy link
Owner

  • createdAt shouldn't be changed in a create -> edit
    // expect(authCode2.createdAt).toBe(authCode.createdAt);
  • maybe type Data so it matches input? is that a breaking change?
  • definitely throw if data is a Map. that's definitely not what we want
  • validate that any key returned in data is an inputKey or storageKey of schemaFields and throw if an unexpected key is found
    • it wasn't working for userID in auth code example so checked for both inputKey and storageKey of fieldInfo but that means we could be sending extra and ignoring it now

follow-up to #1765

@lolopinto
Copy link
Owner Author

also: documentation for data passed in see #1764

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant