Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm run compile doesn't find as many errors as tsc #61

Open
lolopinto opened this issue May 19, 2020 · 0 comments
Open

npm run compile doesn't find as many errors as tsc #61

lolopinto opened this issue May 19, 2020 · 0 comments

Comments

@lolopinto
Copy link
Owner

there may be a missing flag that needs to be passed to the typescript compiler?

errors like this are not found by the new compiler but tsc would have caught it

ola@Olas-personal-MBP simple % tsc          
src/graphql/mutations/generated/contact/create_contact_action_type.ts:67:68 - error TS2345: Argument of type '{ emailAddress: string; firstName: string; lastName: string; }' is not assignable to parameter of type 'ContactCreateInput'.
  Property 'userID' is missing in type '{ emailAddress: string; firstName: string; lastName: string; }' but required in type 'ContactCreateInput'.

 67     let contact = await CreateContactAction.create(context.viewer, {
                                                                       ~
 68       emailAddress: args.emailAddress,
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
... 
 70       lastName: args.lastName,
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 71     }).saveX();
    ~~~~~

  src/ent/contact/actions/generated/create_contact_action_base.ts:16:3
    16   userID: ID | Builder<User>;
         ~~~~~~
    'userID' is declared here.

src/graphql/mutations/generated/event/create_event_action_type.ts:71:64 - error TS2345: Argument of type '{ name: string; startTime: Date; endTime: Date | null | undefined; location: string; }' is not assignable to parameter of type 'EventCreateInput'.
  Property 'creatorID' is missing in type '{ name: string; startTime: Date; endTime: Date | null | undefined; location: string; }' but required in type 'EventCreateInput'.

 71     let event = await CreateEventAction.create(context.viewer, {
                                                                   ~
 72       name: args.name,
    ~~~~~~~~~~~~~~~~~~~~~~
... 
 75       location: args.location,
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 76     }).saveX();
    ~~~~~

  src/ent/event/actions/generated/create_event_action_base.ts:11:3
    11   creatorID: ID | Builder<User>;
         ~~~~~~~~~
    'creatorID' is declared here.


Found 2 errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant