Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disconnected from mqtt #16

Closed
bpaulin opened this issue Jun 1, 2020 · 2 comments · Fixed by #17
Closed

disconnected from mqtt #16

bpaulin opened this issue Jun 1, 2020 · 2 comments · Fixed by #17

Comments

@bpaulin
Copy link
Contributor

bpaulin commented Jun 1, 2020

hello,

this may be related to #2 ... or maybe not
mqtt client sometimes disconnects from mqtt, and fails to publish the next payload.

I'm wondering if we really need to have to have a always connected client? I'd rather use https://pypi.org/project/paho-mqtt/#single to connect-publish-disconnect each time we receive a payload from the scale, it works like that in my setup.

What do you think? are you interested in a PR to change that?

thanks for your work!

@lolouk44
Copy link
Owner

lolouk44 commented Jun 1, 2020

Thanks, that makes sense. Happy with a PR or I can work on it myself. I anyway need to rebuild the container with your earlier changes, which I'll do tonight...

@bpaulin
Copy link
Contributor Author

bpaulin commented Jun 1, 2020

I'll work on a clean PR about that, thanks

bpaulin added a commit to bpaulin/xiaomi_mi_scale that referenced this issue Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants