Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split actions settings #13

Closed

Conversation

diskree
Copy link

@diskree diskree commented Dec 29, 2023

What?

  • Splits settings for sounds from the Actions category to "Bow Pull", "Entity Dies" and "Repeater".
  • Arrange the settings more logically, first the GUI sounds, then the game sounds.

Why?

This gives the player the ability to customize sounds from there individually. For ex, I like the sound of a bow pull, but the "poof" sound of a mob dying annoys me.

Testing Instructions

  1. Launch the game with the mod
  2. Open game sound settings -> Extra sounds settings
  3. Try changing the settings and check the independence between them

Screenshot

image

Changes

Changes have been made to SoundType and Mixers to accommodate the new settings list order as well as the associated code.

Also, it is fully keep to translated into Russian and Korean.

@lonefelidae16
Copy link
Owner

Thanks for your PR. Before merging, could you please tell me about the following questions:

  • Block interaction sounds also include flower pot and campfire sounds. This PR will break these volume settings. Why only for “Repeater”?
  • The GUI sound group that named “Bow Pull” may increase other sounds in the future. Why did you name “Bow Pull”?

This PR was successfully built. If that sound is annoying to you, you can use and redistribute your custom build without asking.

See also #12

@diskree
Copy link
Author

diskree commented Dec 29, 2023

Oh, I should have learn the repository better. Yes, I agree, it is not fully done. Ok, I will fix this in the future and open PR again, maybe.. for now I will distribute my version separately

@diskree diskree closed this Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants