Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working after upgrade to Atom Version 1.23.1 #6

Closed
AnthonyRoberts opened this issue Dec 14, 2017 · 5 comments
Closed

Not working after upgrade to Atom Version 1.23.1 #6

AnthonyRoberts opened this issue Dec 14, 2017 · 5 comments

Comments

@AnthonyRoberts
Copy link

Since updating Atom to version 1.23.1 this no longer works unless the document type is set to HTML. It was working in version 1.22.1 (for text, html, php etc.)

Most of my apps start life as index.php

@lonekorean
Copy link
Owner

Hi Anthony, thanks for this.

It appears to be a new bug Atom's core autocomplete-plus package. One of the effects is that dashes are no longer recognized as part of a term, so "fa-" stopped working. See PR here: atom/autocomplete-plus#928 .

Looks like it's been merged and tagged for release, hopefully with Atom 1.24 (next release). I'll keep an eye on it.

@AnthonyRoberts
Copy link
Author

Excellent news; release 1.23.3 of Atom has fixed the problem.

@lonekorean
Copy link
Owner

Funny story, I actually spent a few hours yesterday on a workaround... then poof, Atom released a new version the same night. :)

However, there seems to be a regression that causes "fa-" to be inserted twice: atom/autocomplete-plus#939

Still working to fix that bit.

@AnthonyRoberts
Copy link
Author

AnthonyRoberts commented Jan 10, 2018 via email

@lonekorean
Copy link
Owner

Alright, got a workaround in place, so I think everything's good again. Just published v0.2.4, give it a spin and let me know if you have any issues.

And no, that's Will Bond. He seems like a cool guy though. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants