feat(Meteor0.8.3): Support Meteor 0.8.3 and prior for ngMeteor v0.2 #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue in ngMeteor-collections.js that would cause upserting to fail because of an invalid ObjectID being passed to collection.update() (as first argument).
This fixes an issue in ngMeteor-collections.js that would cause removing to fail because of an invalid ObjectID being passed to collection.remove() (as first argument). Same fix for upserting.
This reverts commit 1fe9f16.
Added documention for our updated fork to meteor-angular-ui-router
There seems to be two types of ObjectId: - A simple string - Meteor's ObjectId. This commit allows ngMeteor to handle both types.
Merge urigo/ngMeteor v0.2
…r v0.2" This reverts commit 27382bb, as it seems to be causing issues on 0.8.3 and on versions prior to 0.8.2.
… ngMeteor v0.2"" This reverts commit 21e6839.
$$hashKeys will sometimes cause upserting to fail with the below error: > Error: key $$hashKey must not start with '$'
Support both Meteor.Collection.ObjectID() and the default Meteor ID strings
|
Now also includes @leoetlino pull request - Urigo/angular-meteor#1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.