Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pressing return in "Start infiltration" dialog launches the mission #30

Closed
pledbrook opened this issue Feb 24, 2019 · 1 comment
Closed

Pressing return in "Start infiltration" dialog launches the mission #30

pledbrook opened this issue Feb 24, 2019 · 1 comment
Labels
blocker Must be fixed before initial release bug Something isn't working

Comments

@pledbrook
Copy link
Collaborator

Clicking on the "Start infiltration" button works as expected, but pressing the return key bypasses that behaviour and launches the mission.
@pledbrook pledbrook added bug Something isn't working blocker Must be fixed before initial release labels Feb 24, 2019
@pledbrook
Copy link
Collaborator Author

So UISkyrangerArrives calls its OnLaunchedClicked() handler directly rather than using the button's OnClickedDelegate.

We can intercept this behaviour via the community highlander's UIScreenStack.SubscribeToOnInput(), as demonstrated here.

pledbrook added a commit that referenced this issue Apr 2, 2019
@pledbrook
Fix RETURN key for launching infiltrations (#30)
2cd4df8 
Modified the screen listener for `UISkyrangerArrives` so that it intercepts
key presses and ensures that RETURN, SPACEBAR and CONTROLLER A all launch the
infiltration rather than the mission itself.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocker Must be fixed before initial release bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pledbrook